chore: migrate rust/periodic_tasks to icp-cli#1413
Draft
marc0olo wants to merge 1 commit into
Draft
Conversation
Replace dfx.json with icp.yaml using @dfinity/rust@v3.3.0 for both the timer and heartbeat canisters, update ic-cdk to 0.20 and ic-cdk-timers to 1.0 with the new macro syntax, add polling-based Makefile tests, update README to use icp-cli commands, add CI workflow, and remove dfx.json, BUILD.md and the per-example .devcontainer. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dfx.jsonwithicp.yamlusing@dfinity/rust@v3.3.0for thetimerandheartbeatcanistersic-cdkto0.20andic-cdk-timersto1.0; migrates macro syntax fromic_cdk_macros::toic_cdk::Makefilewith polling-basedmake test(no deploy dependency, usesicp canister call --query)README.mdto useicp-clicommands; preserves key educational content about cycles usage differences between timers and heartbeats.github/workflows/periodic_tasks.ymlCI job (ghcr.io/dfinity/icp-dev-env-rust:1.0.0)dfx.json,BUILD.md, and per-example.devcontainer/rust-toolchain.toml(removes pinned channel and components, keepswasm32-unknown-unknowntarget)Test plan
icp network start -d && icp deploy && make testpasses locally inrust/periodic_tasksrust-periodic_taskspasses on this PR🤖 Generated with Claude Code