chore: migrate rust/parallel_calls to icp-cli#1414
Draft
marc0olo wants to merge 1 commit into
Draft
Conversation
Replace dfx.json with icp.yaml (@dfinity/rust@v3.3.0), move sources from src/caller/ and src/callee/ to top-level caller/ and callee/ subdirs, update caller to discover callee via PUBLIC_CANISTER_ID:callee env var (eliminating setup_callee), upgrade ic-cdk to 0.20 with the new Call::bounded_wait API, add Makefile with numbered tests for sequential/parallel behaviour, and add rust-parallel_calls jobs to the existing parallel_calls.yml CI workflow. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dfx.jsonwithicp.yamlusing@dfinity/rust@v3.3.0for bothcallerandcalleecanisterssrc/caller/andsrc/callee/to top-levelcaller/andcallee/subdirs, workspaceCargo.tomlupdated accordinglysetup_callee— the caller now discovers the callee principal at first use viaPUBLIC_CANISTER_ID:calleeinjected by icp-cliic-cdkfrom0.17to0.20and updates inter-canister calls to the newCall::bounded_waitAPI (replacing the removedic_cdk::api::call::call)rust-toolchain.tomlto remove pinned1.78.0channel (too old for current dependencies)Makefilewith 4 numbered tests covering sequential/parallel behavior at both small (n=10) and large (n=2000) call countsrust-parallel_callsandrust-parallel_calls-multi-subnetjobs to the existingparallel_calls.ymlCI workflow; deletes the oldrust-parallel-calls-example.ymlmulti_subnet/PocketIC test is preserved unchanged;make test-multi-subnetbuilds WASMs viacargo buildand runs the cross-subnet timing testTest plan
icp network start -d && icp deploy && make testpasses inrust/parallel_callsmake test-multi-subnetpasses (requires PocketIC server installed)rust-parallel_callsandrust-parallel_calls-multi-subnetpass in the workflowmotoko-parallel_callsCI jobs are unaffected🤖 Generated with Claude Code