chore: migrate rust/canister-info to icp-cli#1415
Draft
marc0olo wants to merge 1 commit into
Draft
Conversation
Replaces dfx.json with icp.yaml, moves src/ → backend/, updates Cargo.toml to a workspace root, upgrades to ic-cdk-management-canister 0.1.1 (replacing the removed ic_cdk::api::management_canister API), rewrites Makefile and README for icp-cli, and adds CI workflow. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dfx.jsonwithicp.yamlusing@dfinity/rust@v3.3.0recipesrc/lib.rs→backend/lib.rs; converts rootCargo.tomlto a workspace manifest pointing atbackend/ic_cdk::api::management_canisterAPI (ic-cdk 0.13) toic-cdk-management-canister = "0.1.1"— adapts to renamed types (CanisterInfoRequest→CanisterInfoArgs,CanisterInfoResponse→CanisterInfoResult,CanisterChange→Change) and the now-optionalChange::detailsfieldMakefilewith five numbered tests calling all public functions viaicp canister call, usingicp canister status backend -ito resolve the backend's own canister ID.github/workflows/canister-info.ymlwith jobrust-canister-infousingghcr.io/dfinity/icp-dev-env-rust:1.0.0README.mdto icp-cli prerequisites and deploy instructions; preserves the link to the IC Interface Specificationdfx.json,BUILD.md,canister-info.did,test.did,test.wasm,.devcontainer/Test plan
rust-canister-infopasses (icp network start -d && icp deploy && make test)info,reflexive_transitive_controllers,canister_controllers,canister_module_hash,canister_deployment_chaincargo check --target wasm32-unknown-unknownpasses locally (verified)🤖 Generated with Claude Code