chore: migrate rust/stake_neuron_from_cli to icp-cli#1417
Draft
marc0olo wants to merge 1 commit into
Draft
Conversation
Converts the dfx-based CLI binary into an icp-cli canister example. Replaces ic-agent/tokio/clap with ic-cdk inter-canister calls, adds icp.yaml (rust@v3.3.0), Makefile with local compute_subaccount tests, CI workflow, and updated README preserving the educational NNS staking domain knowledge. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ic-agent+tokio+clap) into an icp-cli canister that performs NNS neuron staking via inter-canister callsdfx.json+setup_and_run.shwithicp.yaml(@dfinity/rust@v3.3.0) and a workspaceCargo.tomlbackend/lib.rsusingic-cdk 0.20(Call::bounded_wait) with two public endpoints:compute_subaccount(query) andstake_neuron(update)Makefilewith local-testable assertions oncompute_subaccount;stake_neuronrequires mainnet NNS canisters (noted in README and Makefile).github/workflows/stake_neuron_from_cli.yml) usingghcr.io/dfinity/icp-dev-env-rust:1.0.0; removes old dfx-based workflowTest plan
cargo check --target wasm32-unknown-unknownpasses (verified locally)rust-stake_neuron_from_clirunsicp deploy+make testwhich exercisescompute_subaccountlocallystake_neuronendpoint is documented as mainnet-only and tested manually on IC mainnet with a funded canister🤖 Generated with Claude Code