chore(Core): Adjust instruction cost for accessing pages. #10440
Draft
michael-weigelt wants to merge 5 commits into
Draft
chore(Core): Adjust instruction cost for accessing pages. #10440michael-weigelt wants to merge 5 commits into
michael-weigelt wants to merge 5 commits into
Conversation
| @@ -353,7 +355,7 @@ impl DeterministicMemoryTracker { | |||
| } | |||
|
|
|||
| // Charge 1 instruction per OS page accessed. | |||
Contributor
There was a problem hiding this comment.
It's no longer 1 instruction.
| @@ -364,7 +366,7 @@ impl DeterministicMemoryTracker { | |||
| // Charge 1 instruction per OS page dirtied. | |||
| @@ -83,6 +83,8 @@ use crate::checksum; | |||
| #[cfg(feature = "sigsegv_handler_checksum")] | |||
| use std::ops::BitXor; | |||
|
|
|||
| const INSTRUCTION_OVERHEAD_PER_OS_PAGE: u64 = 5_000; | |||
Contributor
There was a problem hiding this comment.
Can't you import DEFAULT_DIRTY_PAGE_OVERHEAD instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow-up PR will refactor and unify the logic and constants.
DO NOT MERGE.