chore: support canister migration from/to deleted subnet in registry#10470
chore: support canister migration from/to deleted subnet in registry#10470mraszyk wants to merge 5 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the registry canister’s canister-migration logic to tolerate migrations involving subnets that have been deleted from the registry/routing table, and adds regression tests to lock in the behavior.
Changes:
- Adjust routing-table mutation so migrating to a target subnet that is absent from the routing table does not leave any ranges assigned to that (deleted) target subnet.
- Relax payload validation to allow migrations to target subnets that no longer exist in the registry.
- Add/extend unit tests covering migration when the source subnet is “deleted” (unrouted gap) and when the target subnet does not exist.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| rs/registry/canister/src/mutations/routing_table.rs | Skips persisting assignments to a target subnet that has no existing ranges in the routing table. |
| rs/registry/canister/src/mutations/do_migrate_canisters.rs | Removes target-subnet existence validation and adds tests for deleted-source / deleted-target migration scenarios. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):
-
Update
unreleased_changelog.md(if there are behavior changes, even if they are
non-breaking). -
Are there BREAKING changes?
-
Is a data migration needed?
-
Security review?
How to Satisfy This Automatic Review
-
Go to the bottom of the pull request page.
-
Look for where it says this bot is requesting changes.
-
Click the three dots to the right.
-
Select "Dismiss review".
-
In the text entry box, respond to each of the numbered items in the previous
section, declare one of the following:
-
Done.
-
$REASON_WHY_NO_NEED. E.g. for
unreleased_changelog.md, "No
canister behavior changes.", or for item 2, "Existing APIs
behave as before.".
Brief Guide to "Externally Visible" Changes
"Externally visible behavior change" is very often due to some NEW canister API.
Changes to EXISTING APIs are more likely to be "breaking".
If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.
If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.
Reference(s)
For a more comprehensive checklist, see here.
GOVERNANCE_CHECKLIST_REMINDER_DEDUP
|
I believe this PR is not worth an entry in the changelog... |
|
✅ No security or compliance issues detected. Reviewed everything up to 7e5ff24. Security Overview
Detected Code Changes
|
This PR supports canister migration from/to deleted subnet in the registry by: