feat: hoist e2fsdroid (from platform-tools) from Dockerfile to Bazel#10490
Open
nmattia wants to merge 3 commits into
Open
feat: hoist e2fsdroid (from platform-tools) from Dockerfile to Bazel#10490nmattia wants to merge 3 commits into
nmattia wants to merge 3 commits into
Conversation
Hoist e2fsdroid out of the Dockerfile and into the Bazel build, like we did for e2fsprogs (mke2fs), dosfstools and mtools. This will still pull the prebuilt binary; we don't build it from source (yet). Instead, this pins the platform-tools archive directly via http_archive and exposes just the prebuilt e2fsdroid binary as //:e2fsdroid. Wire it into the ext4_image rule and build_ext4_image.py the same way as //:mkfs.ext4, so the image build no longer relies on e2fsdroid being on PATH.
This comment was marked as outdated.
This comment was marked as outdated.
basvandijk
approved these changes
Jun 16, 2026
…e8285db62b02ade2b254d17d2af70 ic-build: sha256:2d5964b38af8f9bea12495ea79f4c62a1fc2f6ca688620a0eddf8a60239fad0e ic-dev: sha256:51b4412289f372d4a58363747cfbb1a6207fdf2b092d20ad8daac3b029fb920f
Contributor
|
Run URL: https://github.com/dfinity/ic/actions/runs/27628709281 New container images with tag: |
mbjorkqvist
approved these changes
Jun 16, 2026
Bownairo
approved these changes
Jun 17, 2026
tmu0
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hoist e2fsdroid out of the Dockerfile and into the Bazel build, like we did for e2fsprogs (mke2fs), dosfstools and mtools.
This will still pull the prebuilt binary; we don't build it from source (yet).
Instead, this pins the platform-tools archive directly via http_archive and exposes just the prebuilt e2fsdroid binary as //:e2fsdroid. Wire it into the ext4_image rule and build_ext4_image.py the same way as //:mkfs.ext4, so the image build no longer relies on e2fsdroid being on PATH.