feat: enforce maximum subnet state size from registry in DSM#9299
feat: enforce maximum subnet state size from registry in DSM#9299
Conversation
This reverts commit 50a8d66.
There was a problem hiding this comment.
This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):
-
Update
unreleased_changelog.md(if there are behavior changes, even if they are
non-breaking). -
Are there BREAKING changes?
-
Is a data migration needed?
-
Security review?
How to Satisfy This Automatic Review
-
Go to the bottom of the pull request page.
-
Look for where it says this bot is requesting changes.
-
Click the three dots to the right.
-
Select "Dismiss review".
-
In the text entry box, respond to each of the numbered items in the previous
section, declare one of the following:
-
Done.
-
$REASON_WHY_NO_NEED. E.g. for
unreleased_changelog.md, "No
canister behavior changes.", or for item 2, "Existing APIs
behave as before.".
Brief Guide to "Externally Visible" Changes
"Externally visible behavior change" is very often due to some NEW canister API.
Changes to EXISTING APIs are more likely to be "breaking".
If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.
If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.
Reference(s)
For a more comprehensive checklist, see here.
GOVERNANCE_CHECKLIST_REMINDER_DEDUP
|
Would it be possible to break that down into smaller, reviewable, PRs? Maybe start with the registry, and ignore it in the new fields in the replica in the first PR. The rest could also be broken down into refactor and reading the registry. |
This PR enforces the maximum subnet state size from the registry's subnet record in the DSM.
In more detail, this PR
own_resource_limitstoSystemMetadatainReplicatedState(preserved across checkpoints and overridden at the beginning of every round based on the registry value);subnet_memory_capacityinExecutionEnvironment;StateMachineandExecutionTestframeworks.The subnet resource limits are passed to
ExecutionEnvironmentvia a field inSystemMetadataso that they are also available to non-replicated execution (query handler) which does not have access to the registry.