chore(governance): Add separator before type suffix in integer literals.#9412
Merged
daniel-wong-dfinity-org merged 1 commit intomasterfrom Mar 18, 2026
Conversation
…ned code Fixed numeric literals to use consistent formatting: `42_u64` instead of `42u64`. This improves readability by clearly separating the number from its type suffix. Fixed 168 numeric literals across 53 files in: - rs/nns/: 97 literals in 27 files - rs/sns/: 13 literals in 10 files - rs/nervous_system/: 39 literals in 9 files - rs/registry/: 19 literals in 7 files Generated by running: cargo run -p numeric-separator-fixer -- rs/nns rs/sns rs/nervous_system rs/registry Co-Authored-By: Claude
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
daniel-wong-dfinity-org
dismissed
github-actions[bot]’s stale review
No behavior changes. Just "re-formatting".
jasonz-dfinity
approved these changes
Mar 17, 2026
daniel-wong-dfinity-org
deleted the
separate-integer-literal-type-suffixes-governance
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E.g. change
42u64to42_u64. This improves readability by clearly separating the number from its type suffix.Fixed 168 numeric literals across 53 files.
Changes were made by running
The tool is not yet in
masterbranch; rather, it can be found in draft #9418, which will be sent out for review "very soon".Co-Authored with: Claude