feat: increase storage pricing by 40% (step 2 of 3)#9424
Draft
feat: increase storage pricing by 40% (step 2 of 3)#9424
Conversation
Second step of the 2.5x storage pricing increase approved by motion proposal 140538. Increases gib_storage_per_second_fee from 177,800 to 248,920 cycles (5.6 → 7.84 SDR/GiB/year).
Contributor
There was a problem hiding this comment.
Pull request overview
Implements step 2 of the staged storage pricing rollout by raising the application-subnet storage fee (gib_storage_per_second_fee) by 40%, and updates affected tests to reflect the higher storage/reservation/freezing-threshold related cycle charges.
Changes:
- Increase
gib_storage_per_second_feefrom177_800to248_920cycles/sec in subnet configuration. - Update execution-environment and scheduler tests that depend on storage/freezing-threshold/reservation costs to use the new expected cycle amounts.
- Bump initial cycle balances in a few integration-style tests (e.g., PocketIC gateway, hypervisor) to prevent unintended out-of-cycles behavior under the new pricing.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| rs/config/src/subnet_config.rs | Updates the production application-subnet storage fee constant. |
| rs/execution_environment/tests/subnet_size_test.rs | Updates test config + yearly-cost assertions for the new storage fee. |
| rs/execution_environment/tests/storage_reservation.rs | Adjusts expected reserved-cycles totals driven by storage reservation pricing. |
| rs/execution_environment/tests/hypervisor.rs | Increases initial canister cycles in memory-growth/freezing-threshold tests affected by storage pricing. |
| rs/execution_environment/tests/execution_test.rs | Adjusts cycle amounts in reserved-balance/freezing behavior test to match higher storage costs. |
| rs/execution_environment/src/scheduler/tests/charging.rs | Updates cycle balances used in snapshot deletion/uninstall tests impacted by memory charging. |
| rs/execution_environment/src/execution_environment/tests/canister_snapshots.rs | Updates cycle balances used by snapshot tests to reflect higher reservation/storage costs. |
| rs/execution_environment/src/execution/response/tests.rs | Updates additional-freezing-threshold constants used in DTS response tests. |
| rs/execution_environment/src/execution/call_or_task/tests.rs | Updates additional-freezing-threshold constant used in DTS update test. |
| rs/pocket_ic_server/tests/gateway.rs | Increases cycles provisioned to the II canister to accommodate the higher storage pricing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The actual reserved cycles value from CI is 48,911T, not 48,910T.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gib_storage_per_second_feefrom 177,800 to 248,920 cycles (5.6 → 7.84 SDR/GiB/year)Context
The full rollout plan (4 → 10 SDR/GiB/year) proceeds in three steps: