Skip to content

ci: Enforce that integer type suffix be separated by an underscore.#9428

Closed
daniel-wong-dfinity-org wants to merge 1 commit intoadd-integer-type-suffix-separator-tool-daniel-wongfrom
enforce-integer-type-suffix-separator-daniel-wong
Closed

ci: Enforce that integer type suffix be separated by an underscore.#9428
daniel-wong-dfinity-org wants to merge 1 commit intoadd-integer-type-suffix-separator-tool-daniel-wongfrom
enforce-integer-type-suffix-separator-daniel-wong

Conversation

@daniel-wong-dfinity-org
Copy link
Contributor

@daniel-wong-dfinity-org daniel-wong-dfinity-org commented Mar 17, 2026

This is based on a new tool introduced in #9418. This should not be merged into master until all currently non-compliant code is fixed. That is being done in a bunch of per-team PRs.

In order for this to actually enforce, Claude is telling me that we need to "Add add-integer-type-suffix-separator-status as a required status check". This is something that IDX will need to due, because they have the necessary authority for such things.

@daniel-wong-dfinity-org daniel-wong-dfinity-org changed the base branch from master to add-integer-type-suffix-separator-tool-daniel-wong March 17, 2026 14:58
@daniel-wong-dfinity-org daniel-wong-dfinity-org changed the title Enforce that integer type suffix be separated by an underscore. ci: Enforce that integer type suffix be separated by an underscore. Mar 17, 2026
@github-actions github-actions bot added the ci label Mar 17, 2026
@daniel-wong-dfinity-org daniel-wong-dfinity-org marked this pull request as ready for review March 17, 2026 18:59
@daniel-wong-dfinity-org daniel-wong-dfinity-org requested a review from a team as a code owner March 17, 2026 18:59
Copy link
Collaborator

@basvandijk basvandijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As also mentioned in the PR that introduces the tool, why not simply do this via clippy.

We can additionally extend the autofix job with a cargo clippy --fix step.

@daniel-wong-dfinity-org
Copy link
Contributor Author

I am withdrawing this in favor of #9452.

@daniel-wong-dfinity-org
Copy link
Contributor Author

I hate autofix. I'm pretty sure most people do not expect others (esp not robots) to be adding commits to their PRs. It unexpectedly breaks future git push commands out of nowhere. Such brokenness can be worked around without tremendous effort, but I shouldn't have to do that. It is literally dumping road blocks in my way. Instead, ideally, there should be a one-click fix so that I can see what changes should be made before they get committed (and pushed to GitHub). That way, I know what is going on with code that will have my name on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants