ci: Enforce that integer type suffix be separated by an underscore.#9428
Closed
daniel-wong-dfinity-org wants to merge 1 commit intoadd-integer-type-suffix-separator-tool-daniel-wongfrom
Conversation
Contributor
Author
|
I am withdrawing this in favor of #9452. |
Contributor
Author
|
I hate autofix. I'm pretty sure most people do not expect others (esp not robots) to be adding commits to their PRs. It unexpectedly breaks future |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on a new tool introduced in #9418. This should not be merged into master until all currently non-compliant code is fixed. That is being done in a bunch of per-team PRs.
In order for this to actually enforce, Claude is telling me that we need to "Add add-integer-type-suffix-separator-status as a required status check". This is something that IDX will need to due, because they have the necessary authority for such things.