chore(consensus): Add separator before type suffix in integer literals.#9429
Open
daniel-wong-dfinity-org wants to merge 1 commit intomasterfrom
Open
chore(consensus): Add separator before type suffix in integer literals.#9429daniel-wong-dfinity-org wants to merge 1 commit intomasterfrom
daniel-wong-dfinity-org wants to merge 1 commit intomasterfrom
Conversation
…sus-owned code
Changes 42u64 -> 42_u64, 42i32 -> 42_i32, etc.
The tool was run on the following directories:
rs/artifact_pool
rs/backup
rs/canister_client
rs/config
rs/consensus
rs/crypto
rs/cup_explorer
rs/http_endpoints
rs/http_utils
rs/https_outcalls
rs/ingress_manager
rs/monitoring
rs/orchestrator
rs/p2p
rs/recovery
rs/replay
rs/replica
rs/rust_canisters/proxy_canister
rs/test_utilities/artifact_pool
rs/test_utilities/consensus
rs/test_utilities/in_memory_logger
rs/test_utilities/metrics
rs/validator
rs/types/exhaustive_derive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E.g.
42u64is changed to42_u64.Fix stats: ~176 literals across 73 files.
How to re-create these changes:
add-integer-type-suffix-separator-tool-daniel-wong. Then,bazel build //rs/tools/add-integer-type-suffix-separator.40ad82dbd8) and run the tool against all directories owned by the Consensus team.