Skip to content

chore(idx): Add separator before type suffix in integer literals.#9431

Open
daniel-wong-dfinity-org wants to merge 1 commit intomasterfrom
separate-integer-literal-type-suffixes-idx
Open

chore(idx): Add separator before type suffix in integer literals.#9431
daniel-wong-dfinity-org wants to merge 1 commit intomasterfrom
separate-integer-literal-type-suffixes-idx

Conversation

@daniel-wong-dfinity-org
Copy link
Contributor

@daniel-wong-dfinity-org daniel-wong-dfinity-org commented Mar 17, 2026

E.g. 42u64 is changed to 42_u64.

How to re-create these changes:

  1. Build the tool. It is not in master yet; rather, it is in review in PR 9418. Until that happens, you'll first need to check out add-integer-type-suffix-separator-tool-daniel-wong. Then, bazel build //rs/tools/add-integer-type-suffix-separator.
  1. Then, check out the master commit that this is based on (originally, 40ad82dbd8) and run the tool against all directories owned by the Internal Developer Experience team.
for DIRECTORY in \
    rs/prep \
    rs/tests/idx \
    rs/tests/testnets
do
    ./bazel-bin/rs/tools/add-integer-type-suffix-separator/add-integer-type-suffix-separator $DIRECTORY
done

 code

Changes 42u64 -> 42_u64, 42i32 -> 42_i32, etc.

The tool was run on the following directories:

    rs/prep
    rs/tests/idx
    rs/tests/testnets
@github-actions github-actions bot added the chore label Mar 17, 2026
@daniel-wong-dfinity-org daniel-wong-dfinity-org changed the title chore: Add separator before type suffix in integer literals in idx-ow… chore(idx_: Add separator before type suffix in integer literals. Mar 17, 2026
@daniel-wong-dfinity-org daniel-wong-dfinity-org changed the title chore(idx_: Add separator before type suffix in integer literals. chore(idx): Add separator before type suffix in integer literals. Mar 17, 2026
@daniel-wong-dfinity-org daniel-wong-dfinity-org marked this pull request as ready for review March 17, 2026 18:43
@daniel-wong-dfinity-org daniel-wong-dfinity-org requested a review from a team as a code owner March 17, 2026 18:43
@github-actions github-actions bot added the @idx label Mar 17, 2026
@basvandijk
Copy link
Collaborator

As mentioned in #9418 it would be better to enforce this via clippy rather than built a custom tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants