Skip to content

chore(node): Add separator before type suffix in integer literals.#9434

Merged
daniel-wong-dfinity-org merged 1 commit intomasterfrom
separate-integer-literal-type-suffixes-node
Mar 17, 2026
Merged

chore(node): Add separator before type suffix in integer literals.#9434
daniel-wong-dfinity-org merged 1 commit intomasterfrom
separate-integer-literal-type-suffixes-node

Conversation

@daniel-wong-dfinity-org
Copy link
Contributor

@daniel-wong-dfinity-org daniel-wong-dfinity-org commented Mar 17, 2026 •
edited
Loading

E.g. 42u64 is changed to 42_u64.

Fix stats: ~31 literals across 12 files.

How to re-create these changes:

  1. Build the tool. It is not in master yet; rather, it is in review in PR 9418. Until that happens, you'll first need to check out add-integer-type-suffix-separator-tool-daniel-wong. Then, bazel build //rs/tools/add-integer-type-suffix-separator.
  1. Then, check out the master commit that this is based on (originally, 40ad82dbd8) and run the tool against all directories owned by the Node team.
for DIRECTORY in \
    rs/boundary_node \
    rs/ic_os \
    rs/tests/boundary_nodes \
    rs/tests/nested \
    rs/tests/node
do
    ./bazel-bin/rs/tools/add-integer-type-suffix-separator/add-integer-type-suffix-separator $DIRECTORY
done

git restore \
  rs/ic_os/networking/nss_icos \
  rs/ic_os/metrics/fstrim_tool \
  rs/tests/nested/nns_recovery

@daniel-wong-dfinity-org
chore: Add separator before type suffix in integer literals in node-o…
e8c4031 
…wned code

Changes 42u64 -> 42_u64, 42i32 -> 42_i32, etc.

The tool was run on the following directories:

    rs/boundary_node
    rs/ic_os
    rs/tests/boundary_nodes
    rs/tests/nested
    rs/tests/node
@github-actions github-actions bot added the chore label Mar 17, 2026
@daniel-wong-dfinity-org daniel-wong-dfinity-org changed the title chore: Add separator before type suffix in integer literals in node-o… chore(node): Add separator before type suffix in integer literals. Mar 17, 2026
@daniel-wong-dfinity-org daniel-wong-dfinity-org marked this pull request as ready for review March 17, 2026 18:43
@daniel-wong-dfinity-org daniel-wong-dfinity-org requested a review from a team as a code owner March 17, 2026 18:43
@github-actions github-actions bot added the @node label Mar 17, 2026
@daniel-wong-dfinity-org daniel-wong-dfinity-org added this pull request to the merge queue Mar 17, 2026
Merged via the queue into master with commit af8490f Mar 17, 2026
45 of 46 checks passed
@daniel-wong-dfinity-org daniel-wong-dfinity-org deleted the separate-integer-literal-type-suffixes-node branch March 17, 2026 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frankdavid frankdavid frankdavid approved these changes

@andrewbattat andrewbattat andrewbattat approved these changes

Assignees

No one assigned

Labels

chore @node

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@daniel-wong-dfinity-org @frankdavid @andrewbattat