chore: add ic-xrc-types to workspace dependencies#9443
Draft
jasonz-dfinity wants to merge 2 commits intomasterfrom
Draft
chore: add ic-xrc-types to workspace dependencies#9443jasonz-dfinity wants to merge 2 commits intomasterfrom
jasonz-dfinity wants to merge 2 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR centralizes the ic-xrc-types dependency version by moving several crates from an inline pinned version to using the workspace-managed dependency, and adds ic-xrc-types to the workspace dependency list in the root Cargo.toml.
Changes:
- Switched multiple
rs/*crates fromic-xrc-types = "1.0.0"toic-xrc-types = { workspace = true }. - Added
ic-xrc-types = "1.0.0"under[workspace.dependencies]in the rootCargo.toml.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| rs/tests/testnets/Cargo.toml | Uses workspace-managed ic-xrc-types instead of a crate-local pinned version. |
| rs/nns/test_utils/Cargo.toml | Uses workspace-managed ic-xrc-types instead of a crate-local pinned version. |
| rs/nns/integration_tests/Cargo.toml | Uses workspace-managed ic-xrc-types instead of a crate-local pinned version. |
| rs/nns/cmc/Cargo.toml | Uses workspace-managed ic-xrc-types instead of a crate-local pinned version. |
| rs/nervous_system/integration_tests/Cargo.toml | Uses workspace-managed ic-xrc-types instead of a crate-local pinned version. |
| Cargo.toml | Adds ic-xrc-types to [workspace.dependencies] to support workspace-based dependency declarations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Cargo.toml
Outdated
| ic-transport-types = { version = "0.45.0" } | ||
| ic-utils = { version = "0.45.0", features = ["raw"] } | ||
| ic-vetkeys = "0.6.0" | ||
| ic-xrc-types = "1.0.0" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Several crates pin ic-xrc-types individually at various versions (1.0.0, 1.1.0). The Bazel side already pins ^1.2.0 in rust.MODULE.bazel. This consolidates the Cargo side to match.
What