fix: lookup ID values in metadata items#1835
Merged
Merged
Conversation
HendrikThePendric
force-pushed
the
fix/pivot-table-category-dimension
branch
from
58775c9 to
b431eb6
Compare
4 tasks
janhenrikoverland
previously approved these changes
May 28, 2026
HendrikThePendric
force-pushed
the
fix/pivot-table-category-dimension
branch
from
b431eb6 to
c671cb6
Compare
|
janhenrikoverland
approved these changes
May 28, 2026
dhis2-bot
added a commit
that referenced
this pull request
May 28, 2026
## [29.5.2](v29.5.1...v29.5.2) (2026-05-28) ### Bug Fixes * lookup ID values in metadata items ([#1835](#1835)) ([060b2e2](060b2e2))
Contributor
|
🎉 This PR is included in version 29.5.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-21528
Relates to dhis2/event-visualizer-app#240 this PR is technically unrelated but both bugs cause the app to show ID string instead of display names, so they are functionally related.
Key features
metaData.itemsDescription
This is a generic fix that assumes a text value could be an ID. If this is the case then the item name can be looked up in
metaData.items. If the lookup fails then we assume it must be a genuine free text item.Note about i18n changes
This PR contains significant changes to the POT file. Upon inspection, it turned out that even though these changes are unrelated to the current PR, these are in fact correct. So somehow the POT file on master was stale, which is a bit surprising because the i18n generation runs on pre-commit. I suppose if someone pushed to this repo with a broken git-hooks setup that could explain it.
Known issues
metaData.items. I think we can classify this as being a hypothetical case.Screenshots
supporting text