Skip to content

Appending comments#91

Merged
nedtwigg merged 8 commits into
mainfrom
fix/add-comment-bug
Sep 26, 2025
Merged

Appending comments#91
nedtwigg merged 8 commits into
mainfrom
fix/add-comment-bug

Conversation

@nedtwigg

Copy link
Copy Markdown
Member

@nedtwigg

Copy link
Copy Markdown
Member Author
  • for an issue thread
    • every comment creates a new textarea, and deleting the old preview is the key to good a result
    • easiest thing is to delete very preview where the textarea is dynamically killed, and that's probably a good policy regardless
  • for a PR thread
    • it turns out that there's only one textarea for every appended comment
    • when you append a comment, it reuses the textarea
    • listening to input events doesn't work
    • Mutation Observer does. Huzzah!

@nedtwigg nedtwigg marked this pull request as ready for review September 26, 2025 16:50
@nedtwigg nedtwigg merged commit 843ae03 into main Sep 26, 2025
1 check passed
@nedtwigg nedtwigg deleted the fix/add-comment-bug branch September 26, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants