skpkg: migrate documentation, README, and public static files#13
skpkg: migrate documentation, README, and public static files#13dabeycorn wants to merge 14 commits intodiffpy:migrationfrom dabeycorn:doc
Conversation
Signed-off-by: Dasun Abeykoon <Dasun20202020@hotmail.com>
Signed-off-by: Dasun Abeykoon <Dasun20202020@hotmail.com>
Signed-off-by: Dasun Abeykoon <Dasun20202020@hotmail.com>
Signed-off-by: Dasun Abeykoon <Dasun20202020@hotmail.com>
Signed-off-by: Dasun Abeykoon <Dasun20202020@hotmail.com>
|
@zmx27 @sbillinge ready for review |
|
Thanks @zmx27 these comments look good. Let's keep the documentation templates in case we do build docs later |
Signed-off-by: Dasun Abeykoon <Dasun20202020@hotmail.com>
Signed-off-by: Dasun Abeykoon <Dasun20202020@hotmail.com>
Signed-off-by: Dasun Abeykoon <Dasun20202020@hotmail.com>
Signed-off-by: Dasun Abeykoon <Dasun20202020@hotmail.com>
Signed-off-by: Dasun Abeykoon <Dasun20202020@hotmail.com>
Signed-off-by: Dasun Abeykoon <Dasun20202020@hotmail.com>
Signed-off-by: Dasun Abeykoon <Dasun20202020@hotmail.com>
Signed-off-by: Dasun Abeykoon <Dasun20202020@hotmail.com>
|
@zmx27 ready for review |
|
good progress. Let's get it passing tests and we can merge. |
|
sounds good, let me take a look |
|
btw, it doesn't require me to review to figure out it is failing tests....this is actually your responsibility.... |
Sorry, I knew the test were failing but I was assuming I was supposed to fix it in a separate PR considering this was a problem before migration. |
|
@dabeycorn it seems like tests are failing because pre-commit is failing, so I think you can just fix that on this PR. Otherwise, I think the changes look good |
Signed-off-by: Dasun Abeykoon <Dasun20202020@hotmail.com>
|
I think the pre-commit errors are coming from the migration branch, the workflows don't have proper end of files. I forgot to install pre-commit hooks before doing work there, so that's my bad. |
|
sounds good. Let me know when it is passing and I will merge it. |
|
I don't think I can fix it in this PR because the log says it's a problem with the files in |
|
Please make sure to always make new branches off of the |
|
If this branch was not built from migration then we should not merge it but do the edits over on a clean branch |
Sorry, I started both the
Okay, I'll redo the branch. |
|
If you started them from migration then it is ok. But maybe it is better to do this one again again. Make sure that you are running pre-commit locally |
There currently isn't any documentation so I just added the blank docs project.