Conversation
|
Our current implementation groups all |
|
please see my other comment. I dislike this solution on the basis that it is ugly. I would rather crash with an Error but a really good error message so the users don't freak out. |
|
No more system exit: |
|
The traceback cannot be removed without system exit or if I wrap the entire program in a try except. |
|
Nice. Please see comment. Traceback is fine. It contains more information. |
Which comment? I did not see a new one. The error messages are all tailored to the specific failure-mode already. We have now edited so the actual error mode can be excepted (e.g. except ValueError) |
* Remove PDF language when saving * news
* Robust warning handling * News * Nonews
| def custom_error(self, msg): | ||
| """custom_error(msg : string) | ||
| def morph_error(self, msg, error): | ||
| """morph_error(msg : string) |
There was a problem hiding this comment.
Let's make the docstring a bit better (and also accurate)
| parser.custom_error( | ||
| "Too many arguments. You must only supply a FILE and a DIRECTORY." | ||
| parser.morph_error( | ||
| "Too many arguments. You must only supply a FILE and a DIRECTORY.", |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #292 +/- ##
==========================================
- Coverage 99.93% 99.93% -0.01%
==========================================
Files 24 24
Lines 1480 1479 -1
==========================================
- Hits 1479 1478 -1
Misses 1 1
🚀 New features to boost your workflow:
|
2 participants
Closes #291
