Skip to content

Comments

Refactor default labels from [r],[gr]->[x],[fx] when saving#294

Merged
sbillinge merged 2 commits intodiffpy:mainfrom
Sparks29032:save_pdf
Feb 24, 2026
Merged

Refactor default labels from [r],[gr]->[x],[fx] when saving#294
sbillinge merged 2 commits intodiffpy:mainfrom
Sparks29032:save_pdf

Conversation

@Sparks29032
Copy link
Collaborator

@Sparks29032 Sparks29032 commented Feb 24, 2026

Closes #282

@sbillinge sbillinge merged commit 7da6b72 into diffpy:main Feb 24, 2026
4 of 5 checks passed
@sbillinge
Copy link
Contributor

I merged this failing tests, but it would be good to fix that test to make it less brittle

Sparks29032 added a commit to Sparks29032/diffpy.morph that referenced this pull request Feb 24, 2026
sbillinge pushed a commit that referenced this pull request Feb 24, 2026
* Update error message

* Remove SystemExit

* News

* Refactor default labels from [r],[gr]->[x],[fx] when saving (#294)

* Remove PDF language when saving

* news

* Fixed tests for squeeze morph warnings (#295)

* Robust warning handling

* News

* Nonews
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: saving files assumes PDF data is being analyzed even if its not PDF data

2 participants