Skip to content

Comments

Fixed tests for squeeze morph warnings#295

Merged
sbillinge merged 3 commits intodiffpy:mainfrom
Sparks29032:squeeze_tests
Feb 24, 2026
Merged

Fixed tests for squeeze morph warnings#295
sbillinge merged 3 commits intodiffpy:mainfrom
Sparks29032:squeeze_tests

Conversation

@Sparks29032
Copy link
Collaborator

Closes #288

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small comment.

Further to that comment, I maintain a file ~/dev.txt that contains

scikit-package
gh
pre-commit

so I can just do conda install --file ~/dev.txt whenever I build a new env. Then I have all my dev tooling available. Entropy reduction.....

@@ -0,0 +1,23 @@
**Added:**

* <news item>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs a no-news I think.

easiest is to install scikit-package in your development conda env and the you can use

package add news -n "briefly why a news is not needed"

then git add news and git commit -m news

@Sparks29032
Copy link
Collaborator Author

one small comment.

Further to that comment, I maintain a file ~/dev.txt that contains

scikit-package
gh
pre-commit

so I can just do conda install --file ~/dev.txt whenever I build a new env. Then I have all my dev tooling available. Entropy reduction.....

Yea, I should set this up. I was working in an environment that is at least 2 years old.

@sbillinge sbillinge merged commit 8f9e0ff into diffpy:main Feb 24, 2026
5 checks passed
Sparks29032 added a commit to Sparks29032/diffpy.morph that referenced this pull request Feb 24, 2026
* Robust warning handling

* News

* Nonews
@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.93%. Comparing base (fc45fa1) to head (0764456).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #295   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files          24       24           
  Lines        1480     1494   +14     
=======================================
+ Hits         1479     1493   +14     
  Misses          1        1           
Files with missing lines Coverage Δ
tests/test_morphsqueeze.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sbillinge pushed a commit that referenced this pull request Feb 24, 2026
* Update error message

* Remove SystemExit

* News

* Refactor default labels from [r],[gr]->[x],[fx] when saving (#294)

* Remove PDF language when saving

* news

* Fixed tests for squeeze morph warnings (#295)

* Robust warning handling

* News

* Nonews
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: morph failed CI recently

2 participants