Skip to content

Comments

Deprecate: deprecate remaining functions of Fitrecipe#159

Merged
sbillinge merged 13 commits intodiffpy:v3.3.0from
cadenmyers13:fitrecipe2-dep
Feb 23, 2026
Merged

Deprecate: deprecate remaining functions of Fitrecipe#159
sbillinge merged 13 commits intodiffpy:v3.3.0from
cadenmyers13:fitrecipe2-dep

Conversation

@cadenmyers13
Copy link
Contributor

These are,

boundsToRestraints
getBounds
getBounds2
getNames
getValues
isFree

Additionally, added a test for boundsToRestraints. No tests exists for getBounds and getBound2. When i tried writing a test for them, it seemed that the function is broken. I didnt investigate deeply but i opened an issue. I also improved some docstrings :)

@cadenmyers13
Copy link
Contributor Author

the mentioned issue is here #158

@cadenmyers13
Copy link
Contributor Author

@sbillinge ready for review

@codecov
Copy link

codecov bot commented Feb 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.30%. Comparing base (644cc97) to head (526034d).
⚠️ Report is 15 commits behind head on v3.3.0.

Additional details and impacted files
@@            Coverage Diff             @@
##           v3.3.0     #159      +/-   ##
==========================================
+ Coverage   71.06%   71.30%   +0.23%     
==========================================
  Files          25       25              
  Lines        3660     3690      +30     
==========================================
+ Hits         2601     2631      +30     
  Misses       1059     1059              
Files with missing lines Coverage Δ
tests/test_fitrecipe.py 99.82% <100.00%> (+<0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cadenmyers13
Copy link
Contributor Author

@sbillinge oops this was failing because a typo. its passing now

@sbillinge sbillinge merged commit 03cf0bd into diffpy:v3.3.0 Feb 23, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants