Deprecate: deprecate remaining functions of Fitrecipe#159
Merged
sbillinge merged 13 commits intodiffpy:v3.3.0from Feb 23, 2026
Merged
Deprecate: deprecate remaining functions of Fitrecipe#159sbillinge merged 13 commits intodiffpy:v3.3.0from
Fitrecipe#159sbillinge merged 13 commits intodiffpy:v3.3.0from
Conversation
Contributor
Author
|
the mentioned issue is here #158 |
Contributor
Author
|
@sbillinge ready for review |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3.3.0 #159 +/- ##
==========================================
+ Coverage 71.06% 71.30% +0.23%
==========================================
Files 25 25
Lines 3660 3690 +30
==========================================
+ Hits 2601 2631 +30
Misses 1059 1059
🚀 New features to boost your workflow:
|
Contributor
Author
|
@sbillinge oops this was failing because a typo. its passing now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are,
boundsToRestraintsgetBoundsgetBounds2getNamesgetValuesisFreeAdditionally, added a test for
boundsToRestraints. No tests exists forgetBoundsandgetBound2. When i tried writing a test for them, it seemed that the function is broken. I didnt investigate deeply but i opened an issue. I also improved some docstrings :)