chore: deprecate setLatPar and setLatBase method#163
Merged
sbillinge merged 3 commits intodiffpy:v3.4.0from Feb 23, 2026
Merged
chore: deprecate setLatPar and setLatBase method#163sbillinge merged 3 commits intodiffpy:v3.4.0from
sbillinge merged 3 commits intodiffpy:v3.4.0from
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3.4.0 #163 +/- ##
==========================================
+ Coverage 98.97% 98.99% +0.01%
==========================================
Files 13 13
Lines 1951 1988 +37
==========================================
+ Hits 1931 1968 +37
Misses 20 20
🚀 New features to boost your workflow:
|
sbillinge
reviewed
Feb 23, 2026
src/diffpy/structure/lattice.py
Outdated
| return | ||
|
|
||
| def setLatPar( | ||
| def set_lat_par( |
Contributor
There was a problem hiding this comment.
shall we call this set_latt_parms to make it clearer?
src/diffpy/structure/lattice.py
Outdated
| """ | ||
| return self.set_lat_base(base) | ||
|
|
||
| def set_lat_base(self, base): |
Contributor
There was a problem hiding this comment.
I am not sure what this is tbh, but if we can figure it out, can we give it a better name?
Contributor
Author
There was a problem hiding this comment.
This method sets a new base vector and update the cell length and angles according to the new base. I suggest making it set_new_latt_base_vec maybe?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sbillinge ready to review