feat: add defaultOnlineStyleUrl Expo plugin prop#141
Merged
Conversation
Lets consuming apps override the online map style URL (default: MapLibre demo tiles). Plumbed through app.plugin.js → AndroidManifest meta-data / Info.plist → native NodeJSService → backend argv (5th positional) → createComapeo, with prebuild-time URL validation. Absent → backend keeps its built-in default. Android reuses SentryConfig.readApplicationMetaDataString rather than duplicating the SDK-gated getApplicationInfo read. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
gmaclennan
force-pushed
the
feat/default-online-style-url
branch
from
06ed15c to
ed7bc72
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
defaultOnlineStyleUrlprop to the Expo config plugin so consuming apps can override the online map style URL. Absent → backend keeps its built-in default (MapLibre demo tiles).How it works
app.plugin.jsvalidates the URL at prebuild (must be a non-empty http(s) URL) and writes it to AndroidManifest meta-data / Info.plist. Removing the prop strips the value on a--no-cleanre-prebuild.NodeJSService.{kt,swift}) reads it and forwards it as the 5th argv positional; empty string when unset.backend/index.jsparses the positional;create-comapeo.jsuses it or falls back toDEFAULT_ONLINE_MAP_STYLE_URL.Notes
SentryConfig.readApplicationMetaDataStringinstead of duplicating the SDK-gatedgetApplicationInforead.🤖 Generated with Claude Code