Conversation
|
Fixes #464 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
@AdrianDAlessandro I moved the node documentation to a separate README.md inside the node directory. This seems to have broken the mkdocs build. I tried looking through the code and docs but I can't see how to add this file. |
| ```bash | ||
| npm run styles:expanded | ||
| ``` | ||
| See [node/README.md](https://github.com/direct-framework/direct-webapp/blob/main/node/README.md) for details on working with the NPM-based frontend asset pipeline. |
There was a problem hiding this comment.
🚫 [linkspector] reported by reviewdog 🐶
Cannot reach https://github.com/direct-framework/direct-webapp/blob/main/node/README.md Status: 404
Co-authored-by: Adrian D'Alessandro <a.dalessandro@imperial.ac.uk>
f62472c to
053c4be
Compare
|
@AdrianDAlessandro FYI I've rebased this onto the main branch. |
AdrianDAlessandro
left a comment
There was a problem hiding this comment.
I'll be happy to review and merge this if you can rebase it onto main. Would be good to merge this before looking at moving the node configs into a sub-directory
Description
Some tidying up of the frontend node code related to #529
Fixes #464
Type of change
Key checklist
python -m pytest)mkdocs serve)pre-commit run --all-files)Further checks