Get things working on Debian 10, tcl 8.6 and Tk 8.6#7
Merged
dkfellows merged 4 commits intodkfellows:trunkfrom Feb 5, 2025
Merged
Get things working on Debian 10, tcl 8.6 and Tk 8.6#7dkfellows merged 4 commits intodkfellows:trunkfrom
dkfellows merged 4 commits intodkfellows:trunkfrom
Conversation
+ ; rather than , in shapeSetUpdateOps() argument list. + Redefinition of panic is not required as it is supplied by the tcl 8.6 headers. + Include shapeInt.h rather than shape.h in shapeUnixImpl.c to get definition of ShapeApplyToParent. + Make ordering of Shape_CombineWindow() arguments consistent with the prototype and the documentation. Signed-off-by: Andy Bennett <andyjpb@ashurst.eu.org>
I have `wish` and `wish8.6` executables. 8.X is available almost everywhere these days so assume that `wish` gives us an 8.X `wish` so that we don't have to change this again for every minor version. Signed-off-by: Andy Bennett <andyjpb@ashurst.eu.org>
There are no installation targets provided to install the library in a well-known location. unix/pkgIndex.tcl contains some code to help scripts find the library and to perform a renaming dance but this code isn't available in a well-known location either. ...so this patch simply copy & pastes the snippet from unix/pkgIndex.tcl to where it is needed to make the demos work. The existing definition of `dir` prevents the demos from finding their image resources and isn't compatible with the unix/pkgIndex.tcl library loading trick so this patch also fixes it up so that it works for me. Signed-off-by: Andy Bennett <andyjpb@ashurst.eu.org>
Signed-off-by: Andy Bennett <andyjpb@ashurst.eu.org>
|
|
dkfellows
approved these changes
Feb 5, 2025
Owner
|
I'll need to do a bit more work, but this is definitely a monotonic improvement over what was there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am building this shape extension as follows on Debian 10.
$ cd shape/unix$ ./configure --with-tclconf=/usr/lib/tcl8.6 --with-tkconf=/usr/libIt doesn't work out-of-the-box but after applying the attached patches I get a
unix/libshape04.so.1.0binary.I've also included some patches to get the demos working but I'm less sure of those because there seems to be something I don't understand about how
unix/pkgIndex.tclis supposed to work.Please see the commit messages themselves for all the details.
Hopefully these patches are useful but please let me know if you need any more information.
--
andyjpb