Skip to content

phobos: Fixes for GNU/Hurd.#10980

Merged
thewilsonator merged 1 commit into
dlang:masterfrom
yelninei:phobos-hurd
Jun 16, 2026
Merged

phobos: Fixes for GNU/Hurd.#10980
thewilsonator merged 1 commit into
dlang:masterfrom
yelninei:phobos-hurd

Conversation

@yelninei

Copy link
Copy Markdown
Contributor

Depends on dlang/dmd#22829

@dlang-bot

Copy link
Copy Markdown

Thanks for your pull request and interest in making D better, @yelninei! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#10980"

@yelninei yelninei changed the title phobos: Fixes for GNU/Hurd. WIP: phobos: Fixes for GNU/Hurd. Mar 27, 2026
Comment thread std/process.d
@yelninei yelninei force-pushed the phobos-hurd branch 3 times, most recently from e2d6559 to 6e759f6 Compare March 29, 2026 12:09
@yelninei

Copy link
Copy Markdown
Contributor Author

Failures not caused by D:

  • rename(null, "") : std/file.d:982
  • delete(null) : std/file.d::1117

libc crashes because of the null pointer.

I wont be looking into maybe working around this on the D side for now as the priority is more on getting druntime to work properly, but I want to have this mentioned somewhere

@thewilsonator

Copy link
Copy Markdown
Contributor

thanks, filed as #10997

@yelninei yelninei marked this pull request as ready for review June 16, 2026 14:39
@yelninei yelninei changed the title WIP: phobos: Fixes for GNU/Hurd. phobos: Fixes for GNU/Hurd. Jun 16, 2026
@yelninei

Copy link
Copy Markdown
Contributor Author

I marked the pr in dmd as ready for review (also theoretically there is already precedent to reference nonexistant modules with core.sys.hurd.time)

@thewilsonator thewilsonator merged commit 007f22c into dlang:master Jun 16, 2026
9 of 10 checks passed
@0xEAB 0xEAB added the OS:GNU Hurd Issues/PRs specific to GNU Hurd label Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OS:GNU Hurd Issues/PRs specific to GNU Hurd

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants