std.regex: fix inverted condition in Group.toString#11036
Open
kubo39 wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request and interest in making D better, @kubo39! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#11036" |
A group is matched iff begin <= end (Group.opCast), but toString tested begin < end and so printed matched groups as "(unmatched)" and vice versa. Debug-only output; add a unittest. The unittest's "begin..end" string trips the "space between a .. b" style grep, so exclude ir.d from it as is already done for std/string.d and std/uni/package.d.
kubo39
force-pushed
the
fix-group-tostring-unmatched
branch
from
5f21db8 to
77e21cf
Compare
Member
|
If this is a bug fix, please open or link a corresponding issue. |
Contributor
Author
|
I think it's not necessary, only for debugging purpose. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A group is matched iff begin <= end (Group.opCast), but toString tested begin < end and so printed matched groups as "(unmatched)".