Fix #11035: std.regex: multi-digit backreference silently drops the overshooting digit#11039
Open
kubo39 wants to merge 1 commit into
Open
Conversation
…the overshooting digit \12 with no group 12 was parsed as \1, discarding the trailing digit. Read the full number and error like the single-digit case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
\12 with no group 12 was parsed as \1, discarding the trailing digit.
Read the full number and error like the single-digit case.
I believe this is not a breaking change, perl's disambiguation rule for that never worked before.
Feature request or issue tracking
Closes #11035
Pre-review checklist
[ ] If my changes are non-trivial and do not concern a reported issue, I have added a changelog entry.