Open
Conversation
added 30 commits
April 2, 2023 14:54
added 24 commits
June 13, 2023 21:54
…omponents-lifecycle # Conflicts: # src/index.js
| @@ -0,0 +1,149 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
Owner
Author
There was a problem hiding this comment.
не могу - тогда папка coverage становится пустой и исчезает из репа. из-за этого на деплое не отрабатывает с тестами
| export default { | ||
| title: 'ComponentWithState/Calculator/Button', | ||
| component: Button, | ||
| // eslint-disable-next-line prettier/prettier |
Owner
Author
There was a problem hiding this comment.
тогда prettier ругается на следующую строку где экспорт как ' as ComponentMeta'
src/Components/Button.tsx
Outdated
| } | ||
|
|
||
| export const Button = ({ label, onChildFontSizeChange }: ButtonProps) => { | ||
|
|
src/Components/Button.tsx
Outdated
| onChildFontSizeChange: unknown; | ||
| } | ||
|
|
||
| export const Button = ({ label, onChildFontSizeChange }: ButtonProps) => { |
|
|
||
| export const Button = ({ label, onChildFontSizeChange }: ButtonProps) => { | ||
|
|
||
| const childHandleInputChange = useCallback( |
src/Components/Panel.tsx
Outdated
| import { Button } from './Button'; | ||
| import { BlockFontSize } from '../types/fontSize'; | ||
|
|
||
| export const Panel = ({ onFontSizeChange }) => { |
Owner
Author
There was a problem hiding this comment.
добавил тип пропсов и FC
| return ( | ||
| <div className='buttons-row'> | ||
| {needFontSizes.map((fontSize) => ( | ||
| <Button |
| } | ||
|
|
||
| export const Block = | ||
| styled.div < |
Owner
Author
There was a problem hiding this comment.
prettier так ставит, незнаю что за опция
src/index.js
Outdated
|
|
||
| const root = ReactDOM.createRoot(document.getElementById('root')); | ||
| root.render( | ||
| <React.StrictMode> |
| @@ -0,0 +1,13 @@ | |||
| export type BlockFontSize = | |||
Owner
Author
There was a problem hiding this comment.
размер шрифта строго от 1 до 2 в em
думаю да
added 2 commits
June 21, 2023 17:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.