Conversation
added 30 commits
April 2, 2023 14:54
added 28 commits
June 13, 2023 22:26
…omponents-lifecycle # Conflicts: # src/index.js
# Conflicts: # src/Components/Container.tsx # src/Components/Panel.tsx
profAlexGit
reviewed
Jun 29, 2023
src/Components/Button.tsx
Outdated
| onChildScaleSizeChange: Dispatch<SetStateAction<ScaleSize>>; | ||
| } | ||
|
|
||
| export const Button: React.FC<ButtonProps> = ({ |
There was a problem hiding this comment.
Судя по коду, эта кнопка специфичная, стоит назвать ее так, чтобы было понятно из названия для чего она.
Просто Button вызывает желание использовать ее везде.
Owner
Author
There was a problem hiding this comment.
поменял на ChangeScaleButton
|
|
||
| export function ComponentWithState() { | ||
| const [scaleSize, setScaleSize] = useState<ScaleSize>(1); | ||
| const [xhprof, setXhprof] = useState({}); |
Owner
Author
There was a problem hiding this comment.
xhprof - это php профилировщик, в переменную попадает вся его выгрузка. поменял на xhprofData
src/Services/loadXhprofFromFolder.ts
Outdated
| import { Xhprof } from '../Types'; | ||
| import { Dispatch, SetStateAction } from 'react'; | ||
|
|
||
| const rowLimit: number = 100; |
There was a problem hiding this comment.
Предлагаю сделать DEFAULT_ROW_LIMIT. В функцию передавать rowLimit, чтобы была возможность в программе передавать в функцию другие значения. Тем самым повысится гибкость
Owner
Author
There was a problem hiding this comment.
ок. согласен. добавил значение по умолчанию
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.