Add domain push identifier support and account name#497
Open
Add domain push identifier support and account name#497
Conversation
- Add `new_domain_push_identifier` parameter to `DomainPushInput` - Deprecate `new_account_email` in favor of `new_domain_push_identifier` - Add `name` attribute to `Account` - Update fixtures and tests Closes dnsimple/dnsimple-app#32668
Contributor
Author
Sandbox Integration Test ResultsTested against
|
Contributor
Author
How this was tested
|
Contributor
Author
|
Fixtures PR: dnsimple/dnsimple-developer#971 |
lokst
approved these changes
Apr 6, 2026
Contributor
|
@ggalmazor I realized dnsimple/dnsimple-ruby#462 (comment) may need resolving first |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
new_domain_push_identifierparameter toDomainPushInputnew_account_emailin favor ofnew_domain_push_identifiernameattribute toAccountCloses dnsimple/dnsimple-engineering#425