Skip to content

Add domain push identifier support and account name#497

Open
ggalmazor wants to merge 1 commit intomainfrom
add-domain-push-identifier-and-account-name
Open

Add domain push identifier support and account name#497
ggalmazor wants to merge 1 commit intomainfrom
add-domain-push-identifier-and-account-name

Conversation

@ggalmazor
Copy link
Copy Markdown
Contributor

Summary

  • Add new_domain_push_identifier parameter to DomainPushInput
  • Deprecate new_account_email in favor of new_domain_push_identifier
  • Add name attribute to Account
  • Update fixtures and tests

Closes dnsimple/dnsimple-engineering#425

- Add `new_domain_push_identifier` parameter to `DomainPushInput`
- Deprecate `new_account_email` in favor of `new_domain_push_identifier`
- Add `name` attribute to `Account`
- Update fixtures and tests

Closes dnsimple/dnsimple-app#32668
@ggalmazor
Copy link
Copy Markdown
Contributor Author

Sandbox Integration Test Results

Tested against https://api.sandbox.dnsimple.com using a sandbox user token (dnsimpletest_u_****MIWQ).

/v2/accounts response

Both accounts returned successfully. The name field is correctly deserialized (currently null/nil as the sandbox API does not yet return it — this is expected and will work once the API change is deployed).

Client output

ID: 1324, Email: guillermo.almazor@dnsimple.com, Name: null, Plan: teams-v3-monthly
ID: 2477, Email: guillemo.almazor+corpo@dnsimple.com, Name: null, Plan: corporate-yearly

Unit tests

All unit tests pass ✅

Notes

  • The name field is wired up and ready to deserialize once the API returns it
  • new_domain_push_identifier is a request-only parameter — no sandbox domain push test was run (would require a domain and target account)

@ggalmazor
Copy link
Copy Markdown
Contributor Author

How this was tested

  1. Unit tests — All existing and new unit tests pass. New tests cover:

    • Initiating a domain push with new_domain_push_identifier
    • Asserting the name field on Account
  2. Sandbox integration test — Ran the client against https://api.sandbox.dnsimple.com using a sandbox user token. Verified:

    • /v2/accounts returns successfully and the name field deserializes without error (currently null as the API change is not yet deployed to sandbox)
    • /v2/whoami returns successfully
    • No regressions in existing functionality

@ggalmazor
Copy link
Copy Markdown
Contributor Author

Fixtures PR: dnsimple/dnsimple-developer#971

@lokst
Copy link
Copy Markdown
Contributor

lokst commented Apr 9, 2026

@ggalmazor I realized dnsimple/dnsimple-ruby#462 (comment) may need resolving first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants