Skip to content

Support trustee service in transfers#464

Merged
lokst merged 1 commit intomainfrom
trustee-service-transfers
Apr 15, 2026
Merged

Support trustee service in transfers#464
lokst merged 1 commit intomainfrom
trustee-service-transfers

Conversation

@lokst
Copy link
Copy Markdown
Contributor

@lokst lokst commented Apr 10, 2026

Updated lib/dnsimple/struct/domain_transfer.rb

  • Added attr_accessor :trustee_service to the DomainTransfer struct, so the field from the API response is parsed and accessible

Addresses https://github.com/dnsimple/dnsimple-app/issues/34667
Belongs to https://github.com/dnsimple/dnsimple-business/issues/2641

🔍 QA

(Optional for reviewers)

✅ From the console (adjust account_id, registrant_id, domain_name and base_url accordingly) run bundle exec ruby qa_transfer_trustee.rb

require 'json'
require 'dnsimple'

client = Dnsimple::Client.new(
  base_url: "http://api.dnsimple.localhost:3000",
  access_token: ENV.fetch("TOKEN")
)

account_id = 2
registrant_id = 27
domain_name = "example.com"

# Transfer a domain with trustee service enabled
attributes = { registrant_id: registrant_id, auth_code: "x1y2z3", trustee_service: true }
transfer = client.registrar.transfer_domain(account_id, domain_name, attributes).data
puts "transfer domain_id=#{transfer.domain_id} trustee_service=#{transfer.trustee_service}"

# Get the domain transfer to verify
transfer = client.registrar.get_domain_transfer(account_id, domain_name, transfer.id).data
puts "get transfer id=#{transfer.id} trustee_service=#{transfer.trustee_service}"

QA results

TLD .COM does not support trustee service (Dnsimple::RequestError)
lib/dnsimple/client.rb:173:in 'Dnsimple::Client#execute': Unable to complete transfer at the registrar. Invalid attribute value syntax [Parameter value syntax error; Invalid transfer authorisation code] (Dnsimple::RequestError)

📋 Deployment Pre/Post tasks

  • PRE: Wait till release is ready to be made
  • POST: Create a release version

:shipit: Deployment Verification

  • Verify release is created

@lokst lokst self-assigned this Apr 10, 2026
@lokst lokst marked this pull request as ready for review April 10, 2026 08:41
@lokst lokst requested a review from juankuquintana April 10, 2026 08:46
@lokst lokst merged commit b2ba9ba into main Apr 15, 2026
7 checks passed
@lokst lokst deleted the trustee-service-transfers branch April 15, 2026 07:42
@lokst
Copy link
Copy Markdown
Contributor Author

lokst commented Apr 15, 2026

Released: https://rubygems.org/gems/dnsimple/versions/12.3.0

✅ Tested the new gem with the QA script in Staging

ggalmazor pushed a commit that referenced this pull request Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants