Fix datestring warning and index sorting in timeseries parsing#18
Merged
Conversation
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
wholmgren
reviewed
May 4, 2026
| data["Start of period"] = pd.to_datetime(data["Start of period"]) | ||
| data.set_index("Start of period", inplace=True) | ||
| data.index = data.index.sort_values() | ||
| data.sort_index(inplace=True) |
There was a problem hiding this comment.
inplace=True is discouraged https://pandas.pydata.org/pdeps/0008-inplace-methods-in-pandas.html
| data["date"] = pd.to_datetime(data["date"], utc=True).dt.tz_localize(None) | ||
| data["date"] = pd.to_datetime( | ||
| data["date"], format="%d/%m/%y %H:%M", utc=True | ||
| ).dt.tz_localize(None) |
There was a problem hiding this comment.
Not the point of this PR, but why do we drop the tz from the index? I would have thought explicit UTC is better. Add a comment please
Collaborator
Author
There was a problem hiding this comment.
removed utc alltogether
| data = pd.read_csv(g, sep=";", skiprows=[0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 11, 12]) | ||
| data["date"] = pd.to_datetime(data["date"], utc=True).dt.tz_localize(None) | ||
| data["date"] = pd.to_datetime( | ||
| data["date"], format="%d/%m/%y %H:%M", utc=True |
There was a problem hiding this comment.
is it really true that results are always in utc? I feel like this is not the case
Collaborator
Author
There was a problem hiding this comment.
yes SF API returns local time
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
wholmgren-dnv
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugs fixed:
Tests added (test_handle_timeseries_parsing.py, 9 tests):