Fix incorrect usage of errgroup.WithContext #13480
Open
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hiroto.toyoda <hiroto.toyoda@dena.com>
htoyoda18
force-pushed
the
fix/errgroup-withcontext-usage
branch
from
1e57449 to
2c3ceec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
errgroup.WithContextbut discarding the derived context.errgroup.WithContext, allowing cancellation to properly propagate when one task fails.In cases where cancellation via context is not intended, using a plain
errgroup.Group(e.g.
var eg errgroup.Group) would make the intent clearer than callingWithContextand ignoring the derived context.
Related issue
N/A
(not mandatory) A picture of a cute animal, if possible in relation to what you did