chore(deps): github.com/docker/cli v29.5.3, github.com/docker/buildx v0.34.1, buildkit v0.30.0#13841
chore(deps): github.com/docker/cli v29.5.3, github.com/docker/buildx v0.34.1, buildkit v0.30.0#13841thaJeztah wants to merge 2 commits into
Conversation
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
| _ "github.com/moby/buildkit/util/tracing/childprocess" //nolint:blank-imports | ||
| "github.com/moby/buildkit/util/tracing/detect" | ||
| _ "github.com/moby/buildkit/util/tracing/env" //nolint:blank-imports |
There was a problem hiding this comment.
- This was moved in otel: refactor tracing helpers for child processes moby/buildkit#6707
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This PR bumps docker/cli v29.5.3, docker/buildx v0.34.1, and buildkit v0.30.0 along with related OTEL library updates (otelhttp, otlptrace → v1.43.0, golang.org/x/*).
The only non-trivial code change is in internal/tracing/tracing.go, where the blank-imported tracing registration package is swapped from moby/buildkit/util/tracing/env to moby/buildkit/util/tracing/childprocess to align with the buildkit v0.30.0 API. The existing traceClientFromEnv() function continues to handle OTEL env-var scanning independently, so the swap is safe and the overall tracing behaviour is preserved.
No bugs found in the changed code.
There was a problem hiding this comment.
Pull request overview
Updates core Docker-related Go dependencies (docker/cli, buildx, buildkit) and aligns Compose’s tracing integration with the newer BuildKit tracing packages.
Changes:
- Bump
github.com/docker/clitov29.5.3andgithub.com/docker/buildxtov0.34.1. - Bump
github.com/moby/buildkittov0.30.0and refresh transitive dependency versions ingo.mod/go.sum. - Update BuildKit tracing side-effect import in
internal/tracing/tracing.goto useutil/tracing/childprocess.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/tracing/tracing.go | Updates BuildKit tracing registration import to match the newer BuildKit tracing layout. |
| go.mod | Bumps Docker CLI/buildx/buildkit and updates related indirect dependencies. |
| go.sum | Updates module checksums to reflect the dependency version changes. |
| "github.com/docker/cli/cli/command" | ||
| _ "github.com/moby/buildkit/util/tracing/childprocess" //nolint:blank-imports | ||
| "github.com/moby/buildkit/util/tracing/detect" |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
What I did
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did