Fix default api_type for specific github copilot models#2376
Open
joshbarrington wants to merge 2 commits intodocker:mainfrom
Open
Fix default api_type for specific github copilot models#2376joshbarrington wants to merge 2 commits intodocker:mainfrom
joshbarrington wants to merge 2 commits intodocker:mainfrom
Conversation
Author
|
@liketosweep can you also test this? I've actually ran out of Github Copliot credit 😆 . |
dgageot
previously approved these changes
Apr 10, 2026
|
Hey @joshbarrington, just saw @dgageot gave it the green light! I was getting ready to pull it down but ran out of time on my end tonight before logging off. Thrilled it got approved and is ready to merge though great fix. |
Author
|
@dgageot I just realised it makes sense to call the function earlier inside I'll push that change now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #2303
Some Github Copilot models require the
/responsesendpoint as opposed to/chat/completions.These are not set by default, and so certain models will fail unless a custom agent config is set with
api_type: openai_responses. This sets the default for these models asopenai_responses.@liketosweep