fix: correct bind mount example with conflicting WORKDIR #24125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed WORKDIR from /app to /build so the build output path (/app/hello) does not overlap with the read-only bind mount target. Added clarification about writing output outside the mount point. Fixes docker#22637
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
bot
added
the
area/build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The bind mount example in the cache optimization guide used
WORKDIR /appwithgo build -o /app/hello, causing the build output to be written inside the read-only bind mount target. This fails with:Changed
WORKDIRto/buildso the mount target and output path don't overlap, and added a note explaining that build output must be written outside the bind mount target.Fixes #22637