Skip to content

ENGDOCS-3117b#24649

Merged
aevesdocker merged 3 commits intodocker:mainfrom
aevesdocker:ENGDOCS-3117b
Apr 8, 2026
Merged

ENGDOCS-3117b#24649
aevesdocker merged 3 commits intodocker:mainfrom
aevesdocker:ENGDOCS-3117b

Conversation

@aevesdocker
Copy link
Copy Markdown
Contributor

Description

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 7, 2026

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit e19681a
🔍 Latest deploy log https://app.netlify.com/projects/docsdocker/deploys/69d624484e797100086a2f6a
😎 Deploy Preview https://deploy-preview-24649--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@aevesdocker
Copy link
Copy Markdown
Contributor Author

/review

Copy link
Copy Markdown
Contributor

@docker-agent docker-agent bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🔴 CRITICAL

This PR restructures the settings reference documentation but contains several typos and a duplicate section that need to be fixed before merging.

@aevesdocker aevesdocker marked this pull request as ready for review April 7, 2026 13:50
Copy link
Copy Markdown
Contributor

@akristen akristen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a big improvement. I made a few little nits that shouldn't be blocking.

One thing I'm wondering that might clean up the doc is maybe having a TOC max frontmatter variable that doesn't reveal the h3s in the ToC. I think the benefit of including h3s in some docs is to add context at-a-glance, but this ToC is so long that it's not really glanceable. But hiding the h3s could give it a cleaner/less overwhelming feel. Not a blocker by any means tho and just an idea!

@aevesdocker
Copy link
Copy Markdown
Contributor Author

Thank you @akristen! Added your suggestions including the h3 in the ToC!

@aevesdocker aevesdocker merged commit 2c74da9 into docker:main Apr 8, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants