Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions llamacpp/native/cuda.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ RUN echo "-B build \
-DGGML_NATIVE=OFF \
-DGGML_OPENMP=OFF \
-DGGML_CUDA=ON \
-DCMAKE_CUDA_ARCHITECTURES=61;62;70;75;80;86;89;120;121 \

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The CUDA architectures 120 and 121 are invalid. CUDA compute capabilities (architectures) do not go up to 120 or 121; these numbers likely confuse CUDA software versions (12.0, 12.1) with GPU architectures. Passing these invalid values will cause nvcc to fail during compilation with an error like nvcc fatal : Unsupported gpu architecture 'compute_120'.

Additionally, the list is missing Hopper (90), which is a highly important enterprise GPU architecture (e.g., NVIDIA H100).

Please update the list to use valid compute capabilities, such as 61;62;70;75;80;86;89;90.

    -DCMAKE_CUDA_ARCHITECTURES=61;62;70;75;80;86;89;90 \
References
  1. Focus on correctness, safety, and maintainability — in that order. Critical issues include correctness bugs. (link)

-DCMAKE_CUDA_COMPILER=/usr/local/cuda/bin/nvcc \
-DLLAMA_OPENSSL=OFF \
-GNinja \
Expand Down
Loading