pkg/*: deb: remove redundant override_dh_gencontrol#452
Merged
Conversation
thaJeztah
force-pushed
the
rm_remaining_override
branch
from
2ae34d6 to
47ea41a
Compare
The `--remaining-packages` option was added in [docker-ce-packaging@3e78175], which manually called `dh_gencontrol` for a single package, after which it had to call `dh_gencontrol --remaining-packages` to process the remaining packages as usual. This override was removed, so `dh_gencontrol --remaining-packages` is no longer needed, and we can remove the override. This option was copied to all other packages, which never needed it, so removing it there as well. [docker-ce-packaging@3e78175]: docker/docker-ce-packaging@3e78175 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
rm_remaining_override
branch
from
47ea41a to
c16e33a
Compare
vvoland
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkg/*: deb: remove redundant override_dh_gencontrol
The
--remaining-packagesoption was added in docker-ce-packaging@3e78175,which manually called
dh_gencontrolfor a single package, after which ithad to call
dh_gencontrol --remaining-packagesto process the remainingpackages as usual.
This override was removed, so
dh_gencontrol --remaining-packagesis nolonger needed, and we can remove the override.
This option was copied to all other packages, which never needed it, so
removing it there as well.