Skip to content

feat: export realms from client#472

Merged
Benehiko merged 1 commit intomainfrom
client/realms
Feb 26, 2026
Merged

feat: export realms from client#472
Benehiko merged 1 commit intomainfrom
client/realms

Conversation

@Benehiko
Copy link
Member

No description provided.

Signed-off-by: Alano Terblanche <18033717+Benehiko@users.noreply.github.com>
@Benehiko Benehiko requested a review from joe0BAB February 26, 2026 06:24
Copy link

@docker-agent docker-agent bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

APPROVED — No issues found.

This PR exports realm patterns from the internal x/realms package to provide a stable, versioned public API for external consumers. The code is straightforward:

  • Simple re-exports of constants/variables from the internal package
  • Well-documented with clear explanations of the realm hierarchy
  • No logic errors, resource leaks, or security concerns
  • Pure declaration code with no complex operations

The PR is ready to merge.

@Benehiko Benehiko merged commit 2b851c9 into main Feb 26, 2026
13 checks passed
@Benehiko Benehiko deleted the client/realms branch February 26, 2026 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants