Rework MTX#136
Open
vabold wants to merge 1 commit into
Open
Conversation
vabold
force-pushed
the
mtx
branch
2 times, most recently
from
597a26b to
4bac830
Compare
kiwi515
reviewed
Apr 29, 2026
Report for RSPE01_01 (167f5f6 - a39cd06)📈 Matched code: 33.21% (+0.09%, +3176 bytes) ✅ 21 new matches
🥀 1 broken match
📈 1 improvement in an unmatched item
|
Co-Authored-By: Kiwi <49212064+kiwi515@users.noreply.github.com>
Contributor
Author
|
I moved away from turning off clang-format in favor of something more reinforced. I couldn't fix the ASM macro or get good bracket behavior for the normal keyword, so unfortunately there's no validation there. There are three exceptions I had to make:
|
kiwi515
requested changes
May 23, 2026
| * | ||
| ******************************************************************************/ | ||
|
|
||
| #define DEG2RAD 0.017453292f |
Collaborator
There was a problem hiding this comment.
if we #include <math.h> and define this as (M_PI / 180.0f) does this still match?
| void C_MTXLightOrtho(MtxPtr m, f32 t, f32 b, f32 l, f32 r, f32 scaleS, | ||
| f32 scaleT, f32 transS, f32 transT); | ||
|
|
||
| #define MTXIdentity PSMTXIdentity |
Collaborator
There was a problem hiding this comment.
do we know enough to set all of these based on the build target (release vs. debug)?
| ps_cmpo0 cr0, f7, f6; | ||
| bne nonsingular; | ||
|
|
||
| li r3, 0x0; |
Collaborator
There was a problem hiding this comment.
can we do FALSE/TRUE or can assembly only see macros?
|
|
||
| switch (axis) { | ||
| case 'x': | ||
| case 'X': |
Collaborator
There was a problem hiding this comment.
for consistency, we use curly braces to scope switch cases since it is needed in a few cases:
like this:
case 'X': {
...
}
case ... {|
|
||
| axis |= 0x20; | ||
| switch (axis) { | ||
| case 'x': |
Collaborator
There was a problem hiding this comment.
same braces idea here pls :>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.