docs(ci): document Semgrep gating via Finalize / Final Status#36142
docs(ci): document Semgrep gating via Finalize / Final Status#36142mbiuki wants to merge 1 commit into
Conversation
Semgrep now gates PR-to-merge-queue entry through the PR workflow's finalize job instead of a required status check, which the Semgrep Cloud app never posts on merge_group commits. Refs dotCMS/private-issues#630 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
❌ Linked Issue Needs Team LabelThis PR is linked to issue #630, but that issue has no How to fix this:Apply a This comment was automatically generated by the issue linking workflow |
|
Claude finished @mbiuki's task in 56s —— View job Rollback Safety Analysis
Result: ✅ Safe To RollbackThe only changed file is Analysis against all unsafe categories:
This is a pure documentation change with no code, schema, or configuration impact. Label |
🤖 Codex Review —
|
Proposed Changes
.github/workflows/README.md: Semgrep blocks PRs from entering the merge queue via the PR workflow'sFinalize / Final Status(thesemgrepjob is infinalize'sneeds), not via a required status check.semgrep-cloud-platform/scanto required status checks or re-enable the disabled "Default Merge Queue" ruleset (id 3651671) as-is — the Semgrep Cloud app never posts that check onmerge_groupcommits, which caused the 2026-05-19 merge-queue outage.DISABLE_SEMGREPandSEMGREP_NO_FAIL.This is the documentation part of Option A from dotCMS/private-issues#630. The functional part is repo-variable changes (no code):
DISABLE_SEMGREP=false(done) andSEMGREP_NO_FAIL=false(after canary verification).🤖 Generated with Claude Code