Issue #22:Replaced dot-twigrenderer with mezzio-twigrenderer#23
Issue #22:Replaced dot-twigrenderer with mezzio-twigrenderer#23SergiuBota1 wants to merge 3 commits intomainfrom
Conversation
Signed-off-by: sergiu <sergiubota@rospace.com>
Signed-off-by: sergiu <sergiubota@rospace.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
==========================================
- Coverage 7.94% 0.81% -7.14%
- Complexity 50 577 +527
==========================================
Files 15 81 +66
Lines 214 2092 +1878
==========================================
Hits 17 17
- Misses 197 2075 +1878 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Warning
This is a core file - other projects implementing the Core architecture require it.
Signed-off-by: sergiu <sergiubota@rospace.com>
There was a problem hiding this comment.
By removing these docblocks PHPStan will fail in the other projects implementing the Core architecture.
There was a problem hiding this comment.
we are in a catch 22 here ...
In order to move forward with this project, we need to accept this hack as is
and one laminas_inputfilter will be released and laminas-session, and then will use back dot-twigrendered and fix this issue
We agreed that in practice, the Core submodule will have different branches
This modification is like an compatibility branch
|
we need to find a smarter solution here |
|
@SergiuBota1 Why do you need to modify/remove |
In order to maintain compatibility with PHP 8.4 I replaced dot-twigrenderer with mezzio-twigrenderer.
After removing dot-twigrenderer from composer.json i had to manually require some packages such as:
"psr-mock/http-message-implementation": "^1.0 || ^2.0",-> caused bymezzio/mezziorequiringlaminas/laminas-httphandlerrunnerrequiringpsr/http-message-implementation"laminas/laminas-authentication": "2.18.0",-> used in Core"laminas/laminas-inputfilter": "2.33.0",-> used in Core (I couldn't add it due to a version conflict)When upgrading to a version of dot-twigrenderer that will support PHP 8.4 the required packages are no longer needed and can be removed