Fix empty description help section#2814
Conversation
|
@marko1olo please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ), 1. Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form, “Project” means any of the projects owned or managed by .NET Foundation and offered under a license “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any “Submission” means the Code and any other copyrightable material Submitted by You, including any 2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any 3. Originality of Work. You represent that each of Your Submissions is entirely Your 4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else 5. Licenses. a. Copyright License. You grant .NET Foundation, and those who receive the Submission directly b. Patent License. You grant .NET Foundation, and those who receive the Submission directly or c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. 6. Representations and Warranties. You represent that You are legally entitled to grant the above 7. Notice to .NET Foundation. You agree to notify .NET Foundation in writing of any facts or 8. Information about Submissions. You agree that contributions to Projects and information about 9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and 10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and .NET Foundation dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1. |
| public static Func<HelpContext, bool> SynopsisSection() => | ||
| ctx => | ||
| { | ||
| if (string.IsNullOrWhiteSpace(ctx.Command.Description)) |
There was a problem hiding this comment.
The change is correct but I had to dig a little to see that this method name is wrong. It should be something like CommandDescriptionSection. Would you mind renaming it?
There was a problem hiding this comment.
Renamed in 7829e695 to CommandDescriptionSection() and updated the XML summary as well.
Local checks: git diff --check passed. I couldn't run dotnet test here because this checkout requires SDK 11.0.100-preview.4.26210.111 from global.json, while this machine only has SDK 10.0.202 installed.
7ac030b to
7829e69
Compare
Fixes #2114.
This suppresses the default help
Description:section when the command description is null, empty, or whitespace. Descriptions are optional, so help output should not render an empty section.Changes:
SynopsisSection()now returnsfalsefor null/empty/whitespace descriptions.Description:section.Validation:
git diff --checkNot run locally:
dotnet testforSystem.CommandLine.Testshelp tests.Reason: current machine CPU stayed above the local process gate threshold, so I did not start a .NET test/build process. The change is small and covered by added/updated tests in this PR.