-
Notifications
You must be signed in to change notification settings - Fork 79
Normalize enum names to lowercase in graphminimalpermissionsplugin schema #1524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Updates the JSON schemas for GraphMinimalPermissionsPlugin across multiple versioned schema folders to use lowercase enum values for the type setting, aligning the schema with the lowercase values used in configuration samples and (likely) runtime enum serialization conventions.
Changes:
- Changed
typeenum values from"Delegated"/"Application"to"delegated"/"application"in multiple schema versions. - Updated the
typeproperty description (where present) to reference lowercase values and default.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 14 comments.
Show a summary per file
| File | Description |
|---|---|
| schemas/v2.1.0/graphminimalpermissionsplugin.schema.json | Lowercases type enum values and updates description/default text. |
| schemas/v2.0.0/graphminimalpermissionsplugin.schema.json | Lowercases type enum values and updates description/default text. |
| schemas/v1.3.0/graphminimalpermissionsplugin.schema.json | Lowercases type enum values and updates description/default text. |
| schemas/v1.2.1/graphminimalpermissionsplugin.schema.json | Lowercases type enum values and updates description/default text. |
| schemas/v1.2.0/graphminimalpermissionsplugin.schema.json | Lowercases type enum values and updates description/default text. |
| schemas/v1.1.0/graphminimalpermissionsplugin.schema.json | Lowercases type enum values and updates description/default text. |
| schemas/v1.0.0/graphminimalpermissionsplugin.schema.json | Lowercases type enum values and updates description/default text. |
| schemas/v0.29.2/graphminimalpermissionsplugin.schema.json | Lowercases type enum values and updates description/default text. |
| schemas/v0.29.1/graphminimalpermissionsplugin.schema.json | Lowercases type enum values and updates description/default text. |
| schemas/v0.29.0/graphminimalpermissionsplugin.schema.json | Lowercases type enum values and updates description/default text. |
| schemas/v0.28.0/graphminimalpermissionsplugin.schema.json | Lowercases type enum values and updates description/default text. |
| schemas/v0.27.0/graphminimalpermissionsplugin.schema.json | Lowercases type enum values and updates description/default text. |
| schemas/v0.26.0/graphminimalpermissionsplugin.schema.json | Lowercases type enum values (no description in this schema version). |
| schemas/v0.25.0/graphminimalpermissionsplugin.schema.json | Lowercases type enum values (no description in this schema version). |
| "Delegated", | ||
| "Application" | ||
| "delegated", | ||
| "application" |
Copilot
AI
Feb 7, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The schema enum now only permits lowercase values ('delegated'/'application'). This is a breaking change for configs (and editor validation) that still use the previously-documented 'Delegated'/'Application' values, especially for people pinning older schema URLs. Consider allowing both casings in the enum (or introducing a new schema version and leaving historical schemas unchanged).
| "application" | |
| "application", | |
| "Delegated", | |
| "Application" |
| "Delegated", | ||
| "Application" | ||
| "delegated", | ||
| "application" |
Copilot
AI
Feb 7, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The schema enum now only permits lowercase values ('delegated'/'application'). This is a breaking change for configs (and editor validation) that still use the previously-documented 'Delegated'/'Application' values, especially for people pinning older schema URLs. Consider allowing both casings in the enum (or introducing a new schema version and leaving historical schemas unchanged).
| "application" | |
| "Delegated", | |
| "application", | |
| "Application" |
| "Delegated", | ||
| "Application" | ||
| "delegated", | ||
| "application" |
Copilot
AI
Feb 7, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The schema enum now only permits lowercase values ('delegated'/'application'). This is a breaking change for configs (and editor validation) that still use the previously-documented 'Delegated'/'Application' values, especially for people pinning older schema URLs. Consider allowing both casings in the enum (or introducing a new schema version and leaving historical schemas unchanged).
| "application" | |
| "Delegated", | |
| "application", | |
| "Application" |
| "Delegated", | ||
| "Application" | ||
| "delegated", | ||
| "application" |
Copilot
AI
Feb 7, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The schema enum now only permits lowercase values ('delegated'/'application'). This is a breaking change for configs (and editor validation) that still use the previously-documented 'Delegated'/'Application' values, especially for people pinning older schema URLs. Consider allowing both casings in the enum (or introducing a new schema version and leaving historical schemas unchanged).
| "application" | |
| "Delegated", | |
| "application", | |
| "Application" |
| "enum": [ | ||
| "Delegated", | ||
| "Application" | ||
| "delegated", | ||
| "application" | ||
| ], | ||
| "description": "Determines which type of permission scopes to return. Can be 'Delegated' or 'Application'. Default: 'Delegated'." | ||
| "description": "Determines which type of permission scopes to return. Can be 'delegated' or 'application'. Default: 'delegated'." |
Copilot
AI
Feb 7, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The schema enum now only permits lowercase values ('delegated'/'application'). This is a breaking change for configs (and editor validation) that still use the previously-documented 'Delegated'/'Application' values, especially for people pinning older schema URLs. Consider allowing both casings in the enum (or introducing a new schema version and leaving historical schemas unchanged).
| "Delegated", | ||
| "Application" | ||
| "delegated", | ||
| "application" |
Copilot
AI
Feb 7, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The schema enum now only permits lowercase values ('delegated'/'application'). This is a breaking change for configs (and editor validation) that still use the previously-documented 'Delegated'/'Application' values, especially for people pinning older schema URLs. Consider allowing both casings in the enum (or introducing a new schema version and leaving historical schemas unchanged).
| "application" | |
| "Delegated", | |
| "application", | |
| "Application" |
| "enum": [ | ||
| "Delegated", | ||
| "Application" | ||
| "delegated", | ||
| "application" | ||
| ], | ||
| "description": "Determines which type of permission scopes to return. Can be 'Delegated' or 'Application'. Default: 'Delegated'." | ||
| "description": "Determines which type of permission scopes to return. Can be 'delegated' or 'application'. Default: 'delegated'." |
Copilot
AI
Feb 7, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The schema enum now only permits lowercase values ('delegated'/'application'). This is a breaking change for configs (and editor validation) that still use the previously-documented 'Delegated'/'Application' values, especially for people pinning older schema URLs. Consider allowing both casings in the enum (or introducing a new schema version and leaving historical schemas unchanged).
| "Delegated", | ||
| "Application" | ||
| "delegated", | ||
| "application" |
Copilot
AI
Feb 7, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The schema enum now only permits lowercase values ('delegated'/'application'). This is a breaking change for configs (and editor validation) that still use the previously-documented 'Delegated'/'Application' values, especially for people pinning older schema URLs. Consider allowing both casings in the enum (or introducing a new schema version and leaving historical schemas unchanged).
| "application" | |
| "Delegated", | |
| "application", | |
| "Application" |
| "Delegated", | ||
| "Application" | ||
| "delegated", | ||
| "application" |
Copilot
AI
Feb 7, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The schema enum now only permits lowercase values ('delegated'/'application'). This is a breaking change for configs (and editor validation) that still use the previously-documented 'Delegated'/'Application' values, especially for people pinning older schema URLs. Consider allowing both casings in the enum (or introducing a new schema version and leaving historical schemas unchanged).
| "application" | |
| "application", | |
| "Delegated", | |
| "Application" |
| "Delegated", | ||
| "Application" | ||
| "delegated", | ||
| "application" |
Copilot
AI
Feb 7, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The schema enum now only permits lowercase values ('delegated'/'application'). This is a breaking change for configs (and editor validation) that still use the previously-documented 'Delegated'/'Application' values, especially for people pinning older schema URLs. Consider allowing both casings in the enum (or introducing a new schema version and leaving historical schemas unchanged).
| "application" | |
| "application", | |
| "Delegated", | |
| "Application" |
No description provided.