Extract IImageNameResolver interface and unify implementation#2039
Draft
lbussell wants to merge 1 commit intodotnet:mainfrom
Draft
Extract IImageNameResolver interface and unify implementation#2039lbussell wants to merge 1 commit intodotnet:mainfrom
lbussell wants to merge 1 commit intodotnet:mainfrom
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts an
IImageNameResolverinterface from the abstractImageNameResolverclass, enabling clean mocking in tests. Collapses the two subclasses (ImageNameResolverForBuildandImageNameResolverForMatrix) into a single concrete class using aDigestResolutionModeenum to control the one behavioral difference in digest queries. MovesIsInRegistryout ofDockerHelperand intoImageNameResolveras a private method, since it is the only consumer. All 448 existing tests pass with no changes to behavior.