Remove unnecessary Docker login from CleanAcrImagesCommand#2044
Merged
lbussell merged 1 commit intodotnet:mainfrom Mar 24, 2026
Merged
Remove unnecessary Docker login from CleanAcrImagesCommand#2044lbussell merged 1 commit intodotnet:mainfrom
lbussell merged 1 commit intodotnet:mainfrom
Conversation
The cleanup command wrapped operations in ExecuteWithCredentialsAsync, which tried to Docker-login using the registry's service connection from publishConfig.RegistryAuthentication. That service connection was not referenced in the pipeline stage, causing Azure DevOps to refuse OIDC token issuance. The Docker login was unnecessary - all ACR operations authenticate directly via cleanServiceConnection through the Azure SDK. Removing the wrapper and the unused IRegistryCredentialsProvider dependency fixes the pipeline failure. Fixes dotnet#2028 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mthalman
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cleanup command wrapped operations in
ExecuteWithCredentialsAsync, which tried to Docker-login using the registry's service connection frompublishConfig.RegistryAuthentication. That service connection was not referenced in the pipeline stage, causing Azure DevOps to refuse OIDC token issuance.The Docker login was unnecessary - all ACR operations authenticate directly via
cleanServiceConnectionthrough the Azure SDK. Removing the wrapper and the unusedIRegistryCredentialsProviderdependency should fix the pipeline failure.Fixes #2028