Fix pruneEol not deleting expired images due to oras output format change#2046
Merged
lbussell merged 1 commit intodotnet:mainfrom Mar 24, 2026
Merged
Fix pruneEol not deleting expired images due to oras output format change#2046lbussell merged 1 commit intodotnet:mainfrom
lbussell merged 1 commit intodotnet:mainfrom
Conversation
…ange Newer versions of oras changed the `discover --format json` output to use a `referrers` property instead of `manifests`. OrasDiscoverData only had a `Manifests` property, so deserialization always produced null and HasExpiredEol returned false for every image. Add a `Referrers` property to OrasDiscoverData and fall back to it when `Manifests` is null, supporting both old and new oras output formats.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2045
Newer versions of oras changed the
discover --format jsonoutput to use areferrersproperty instead ofmanifests. OrasDiscoverData only had aManifestsproperty, so deserialization always produced null and HasExpiredEol returned false for every image.Add a
Referrersproperty to OrasDiscoverData and fall back to it whenManifestsis null, supporting both old and new oras output formats.This breaking change was made in https://github.com/oras-project/oras/releases/tag/v1.3.0: